[Buildroot] [PATCH v12 01/32] toolchain: add option to copy the gconv libraries

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jun 8 13:15:17 UTC 2014


Bernd, Yann,

On Sat,  7 Jun 2014 14:31:01 +0200, Bernd Kuhls wrote:

> +config BR2_COPY_GCONV_LIBS
> +	bool "copy gconv libs"
> +	depends on BR2_TOOLCHAIN_USES_GLIBC

A few comments about this patch:

 - I dislike the name of the option. Maybe it should be
   BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY or something like that.

 - There should be a sub-option or something to copy only a subset of
   the gconv library, with a sane, default set of gconv libraries.
   Maybe with a choice "copy all" / "copy a selection".

 - Packages that needs gconv libraries should select this option.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list