[Buildroot] [PATCH 1/2] apply-patches.sh: don't print anything when "-s" option is used
fabio.porcedda at gmail.com
Fri Jul 25 16:42:24 UTC 2014
On Mon, Jul 21, 2014 at 7:26 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Fabio, All,
> On 2014-07-09 13:46 +0200, Fabio Porcedda spake thusly:
>> The make "-s" option is used to enable the "Silent operation" so if
>> that option is used don't print anything as far as there isn't any
>> Add the "-s" option to "apply-patches.sh" to enable silent operation.
>> Because "apply-patches.sh" is called in many places add a
>> "APPLY_PATCHES" variable to permit adding the "-s" easily.
>> Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
> OK, this patch does two things:
> - introduce the APPLY_PATCHES variable, to be used instead of
> duplicating support/scripts/apply-patches.sh everywhere,
> - add the -s option to apply-patches
> So, it should be split in two.
> I did not initially notice that appy-patches was not always made silent,
> but that it was conditional to the user using 'make -s' in the first
> So, I would not oppose that patch. After all, if the user uses make -s,
> and it is not really complicated to propagate that to our sub-tools,
> that's pretty OK.
> However, see below...
>> diff --git a/package/Makefile.in b/package/Makefile.in
>> index 97053ba..e1fdb4d 100644
>> --- a/package/Makefile.in
>> +++ b/package/Makefile.in
>> @@ -218,6 +218,12 @@ FLEX:=$(shell which flex || type -p flex)
>> BISON:=$(shell which bison || type -p bison)
>> SED:=$(shell which sed || type -p sed) -i -e
>> +ifeq (,$(findstring s,$(MAKEFLAGS)))
>> +APPLY_PATCHES = support/scripts/apply-patches.sh
>> +APPLY_PATCHES = support/scripts/apply-patches.sh -s
> I would do:
> BR_SILENT = $(if $(findstring s,$(MAKEFLAGS)),YES)
> APPLY_PATCHES = support/scripts/apply-patches.sh $(if $(BR_SILENT),-s)
> That way, we can re-use $(BR_SILENT) for other tools (I'm thinking of
> graph-depends and our other custom tools in support/scripts/ .)
I've sent a new revision:
Thanks and best regards
More information about the buildroot