[Buildroot] [PATCH v14 03/20] package/mesa3d: add dependency xproto_presentproto

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jul 15 19:22:20 UTC 2014


Dear Bernd Kuhls,

On Tue, 15 Jul 2014 21:18:58 +0200, Bernd Kuhls wrote:
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
>  package/mesa3d/Config.in |    1 +
>  package/mesa3d/mesa3d.mk |    1 +
>  2 files changed, 2 insertions(+)

Please add a justification about this change in the commit log. Is it
needed following the mesa3d bump? In this case, it should be part of
the patch bumping mesa3d.

Bernd, a good rule of thumb is *all* patches should have a commit log.
So whenever you're about to send a series, please review the commit log
of your patches, and make sure all of them have a non-empty commit log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list