[Buildroot] [PATCH] grub2: Specify boot partition

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jul 1 09:14:13 UTC 2014

Dear Jérôme Pouiller,

On Tue,  1 Jul 2014 10:44:49 +0200, Jérôme Pouiller wrote:
> Since boot partition was not specified, grub tools try to detect it
> automatically. This patch add an option to force it.
> Notice I am not sure -p option is usefull when -c option is used.

This should not be part of the commit log. If you want to express such
comments, they should go...

> Signed-off-by: Jérôme Pouiller <jezz at sysmic.org>
> ---

... here.

Indeed, when the configuration is built into the image, I don't think
the prefix is very useful. But I believe that's OK.

> +	string "boot partition"
> +	default "(hd0,msdos1)"

	depends on BR2_TARGET_GRUB2_I386_PC

since there is no need to specify a boot partition for the EFI boot

> +	  Specifiy partition where /boot/grub/grub.cfg will be located.

Fix that with:

	Specify the partition where the /boot/grub/grub.cfg is located.
	Use (hd0,msdos1) for the first partition of the first disk if
	using a legacy partition table, or (hd0,gpt1) if using GPT
	partition table.

Other than that, looks OK. Can you quickly resend a v2 ?

Thanks a lot for looking into this problem!

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering

More information about the buildroot mailing list