[Buildroot] [PATCH] libv4l: Bump version to 1.0.1
thomas.petazzoni at free-electrons.com
Tue Jul 1 21:26:48 UTC 2014
Dear Ezequiel Garcia,
On Sun, 29 Jun 2014 18:18:34 -0300, Ezequiel Garcia wrote:
> -config BR2_PACKAGE_LIBV4L_V4L2_CTL
> - bool "v4l2-ctl"
> - depends on BR2_INSTALL_LIBSTDCPP
> +config BR2_PACKAGE_LIBV4L_JPEG
> + bool "JPEG support"
I think there needs to be a justification as to why we want a
sub-option to enable jpeg support, as opposed to have it directly
handled as an optional dependency in the .mk file by testing
> -comment "libv4l needs a toolchain w/ largefile, threads"
> +comment "libv4l needs a toolchain w/ largefile, threads and C++"
> depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> + depends on !BR2_INSTALL_LIBSTDCPP
The main problem is here, you should use:
depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
Otherwise, the comment will not get displayed in the proper situations.
Can you fix that up and resend?
Thanks a lot!
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the buildroot