[Buildroot] [PATCH v5 06/15] gpu-viv-bin-mx6q: change output selection mechanism

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Dec 27 20:38:14 UTC 2014


Dear Jérôme Pouiller,

On Tue,  9 Dec 2014 14:46:44 +0100, Jérôme Pouiller wrote:
>   - Move output selection to Config.in. It easier to add new
>     backends selection (wayland, directfb, ...).
>   - Remove useless build time dependencies xlib_libXdamage
>     and xlib_libXext (gpu-viv-bin-mx6q is provided as binary
>     package)

Then please adjust the Config.in file to indicate that those are
runtime dependencies only.

>   - Also create libraries symbolic links with version numbers.

Another thing I could suggest is to further split such a patch: you
have three items in your commit log, that are independent from each
other, so it is a good indication that the patch could be split.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list