[Buildroot] [PATCH v5 2/4] Makefile: improve detection of make "-s" flag

Fabio Porcedda fabio.porcedda at gmail.com
Tue Dec 23 08:54:59 UTC 2014


Because it's just checked the presence of the "s" character even a
  make --warn-undefined-variables
is detected as a silent build so fix this by filtering out long options.

Signed-off-by: Fabio Porcedda <fabio.porcedda at gmail.com>
Cc: Arnout Vandecappelle <arnout at mind.be>
---

Notes:
    v5:
     - remove spaces after commas (Yann)
    v4:
     - split this patch from the patch set to send to muster as bugfix
    v2:
     - remove spurious space at the beginning of the QUIET variable (Arnout)
    
    v4:
     - split this patch from the patch set to send to muster as bugfix
    v2:
     - remove spurious space at the beginning of the QUIET variable (Arnout)

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 3baa709..e94df7a 100644
--- a/Makefile
+++ b/Makefile
@@ -303,7 +303,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess)
 TARGETS :=
 
 # silent mode requested?
-BR_QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q)
+BR_QUIET := $(if $(findstring s,$(filter-out --%,$(MAKEFLAGS))),-q)
 
 # Strip off the annoying quoting
 ARCH := $(call qstrip,$(BR2_ARCH))
-- 
2.2.1




More information about the buildroot mailing list