[Buildroot] [PATCH 1/1] ncurses: add support for 256 colors

Yann E. MORIN yann.morin.1998 at free.fr
Fri Dec 12 22:46:21 UTC 2014


Thierry, All,

On 2014-12-12 23:43 +0100, Thierry Bultel spake thusly:
> Le 11/12/2014 19:14, Yann E. MORIN a écrit :
> >On 2014-12-09 15:48 +0100, Thierry Bultel spake thusly:
> >>Le 09/12/2014 13:21, Gustavo Zacarias a écrit :
> >>>On 12/09/2014 07:58 AM, Thierry Bultel wrote:
> >>>
> >>>>+config BR2_PACKAGE_NCURSES_EXT_COLORS
> >>>>+	bool "ncurses extended colors"
> >>>>+	select BR2_PACKAGE_NCURSES_WCHAR
> >>>>+	depends on BR2_USE_WCHAR
> >>>>+	help
> >>>>+	  compile for 256-color support
> >>>>+
> >>>
> >>>Hi.
> >>>Do you know the size delta between this option enabled and disabled?
> >>>I'm asking because it might not be even worth an option.
> >>>Thanks.
> >>>Regards.
> >>>
> >>
> >>Hi, the size delta is quite small:
> >>
> >>256 colors:
> >>
> >>-rwxr-xr-x 1 thierry thierry 210K déc.   9 14:23
> >>output/target/usr/lib/libncursesw.so.6.0
> >>
> >>std colors:
> >>
> >>-rwxr-xr-x 1 thierry thierry 202K déc.   9 15:46
> >>output/target/usr/lib/libncursesw.so.5.9
> >
> >Then, I'd say we just enable it by default, since the size delta is
> >negligible (~4%).
> >
> 
> Shall I then repost the patch with 256 colors enabled by default ?

Yes. Just repeat in the commit log the size values you observed as a
reason not to make it an option.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list