[Buildroot] [PATCH 1/1] screen: add support for 256 colors

Baruch Siach baruch at tkos.co.il
Tue Dec 9 15:57:28 UTC 2014


Hi Vicente, Thierry,

On Tue, Dec 09, 2014 at 03:39:01PM +0000, Vicente Olivert Riera wrote:
> On 12/09/2014 03:26 PM, Thierry Bultel wrote:
> 
> >  define SCREEN_INSTALL_SCREENRC
> > -	$(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc
> > +	if [ ! -f $(TARGET_DIR)/etc/screenrc ]; then \
> > +		$(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc; \
> > +	fi
> >  endef
> >  
> >  SCREEN_POST_INSTALL_TARGET_HOOKS += SCREEN_INSTALL_SCREENRC
> 
> This part is not related with adding support for 256 colors, so, why
> don't you send a separate patch for it? Or at least, state in your
> commit message you are fixing a little issue with the 'screenrc' file
> installation. But I would say that a separate patch would be better.

I don't think the change in this separate patch is desired. We have just 
recently (commit 963bbf266bfebc [screen: install configuration file 
unconditionally]) switched to unconditional install of the config file.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list