[Buildroot] [PATCH 1/1] package/minidlna: fix static linking with OpenSSL enabled

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Dec 7 21:52:54 UTC 2014


Dear Yann E. MORIN,

On Sun, 7 Dec 2014 22:10:25 +0100, Yann E. MORIN wrote:

> I'm not too fond of the way this is handled. I'd prefer we get something
> like:
> 
>     MINIDLNA_LIBS = -lavformat -lavcodec -lavutil -logg
>     MINIDLAN_LIBS += $(if $(BR2_PACKAGE_OPENSSL),-lssl -lcrypto)
>     MINIDLAN_LIBS += -lz -lpthread -lm
> 
>     MINIDLNA_CONF_ENV = LIBS='$(MINIDLNA_LIBS)'

Agreed, with maybe "$(MINIDLNA_LIBS)" instead of simple quotes.

A further possible improvement would be to switch to use pkg-config
instead, so that this becomes more maintainable :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list