[Buildroot] [PATCH 1/3 v3] package/mke2img: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Dec 6 18:20:32 UTC 2014

Dear Yann E. MORIN,

On Sat,  6 Dec 2014 13:29:44 +0100, Yann E. MORIN wrote:

> This new script is highly modeled from the existing genext2fs.sh, but
> was slightly refreshed, and a new, supposedly sane set of options has
> been choosen for the features we need (see above), and some new options
> were added, too, rather than relying on the arguments order or
> environment variables:
>   -b <nb-blocks>    number of blocks in the filesystem
>   -i <nb-inodes>    number of inodes in the filesystem
>   -r <pc-reserved>  percentage of reserved blocks
> * -d <root-dir>     directory containing the root of the filesystem
> * -o <img-file>     output image file
> * -G <ext-gen>      extfs generation: 2, 3, or 4
> * -R <ext-rev>      ext2 revision: 0 or 1 (1 is assumed for ext3 and ext4)
>   -l <label>        filesystem label
>   -u <uid>          filesystem UUID; if not specified, a random one is used
> * Mandatory options

What about putting this in a "help" of the mke2img tool, or at least in
the comment header at the beginning of the script?

> +    # genext2fs does not generate a UUID, but fsck will whine if one is
> +    # is missing, so we need to add a UUID.

duplicate "is".

> +    # Of course, this has to happend _before_ we run fsck.

happend -> happen

> +    # Also, some ext4 metadata are based on the UUID, so we must
> +    # set it before we can convert the filesystem to ext4.
> +    # If the user did not specify a UUID, we generate a random one.
> +    # Although a random UUID may seem bad for reproducibility, there
> +    # already are so many things that are not reproducible in a

s/already are/are already/

Other than that, looks good.

Tested-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

 (on x86-64 in qemu, tested an ext4 filesystem with only the ext4
 kernel driver compiled in, and then tested an ext2 filesystem with
 only the ext2 kernel driver compiled in).


Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering

More information about the buildroot mailing list