[Buildroot] [PATCH 3/3 v2] fs/ext2: add option to specify a filesystem label

Károly Kasza kaszak at gmail.com
Sat Dec 6 11:59:42 UTC 2014


Hi Yann, Thomas, list,

--- a/fs/ext2/ext2.mk
> +++ b/fs/ext2/ext2.mk
> @@ -18,6 +18,12 @@ ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_RESBLKS)),0)
>  EXT2_OPTS += -r $(BR2_TARGET_ROOTFS_EXT2_RESBLKS)
>  endif
>
> +# Not qstrip-ing the variable, because it may contain spaces,
> +# but we must qstrip it when checking.
> +ifneq ($(call qstrip,$(BR2_TARGET_ROOTFS_EXT2_LABEL)),)
> +EXT2_OPTS += -l $(BR2_TARGET_ROOTFS_EXT2_LABEL)
>

Unfortunately this won't work with labels with spaces in them.
I recommend using escaped quotation marks like this:

+EXT2_OPTS += -l \"$(BR2_TARGET_ROOTFS_EXT2_LABEL)\"
>

---

Tested the whole series of 3 together, successfully built different
rootfs.ext images and booted them.
Tested with master branch, x86_64 arch in QEMU, internal toolchain GCC
4.9.2 w/ uclibc, Linux 3.17.4.

Regards,
Karoly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141206/7beb7270/attachment-0002.html>


More information about the buildroot mailing list