[Buildroot] [PATCH 2/2] rp-pppoe: install helper scripts

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Dec 3 22:39:39 UTC 2014


Dear Thomas Petazzoni,

On Wed, 3 Dec 2014 23:38:32 +0100, Thomas Petazzoni wrote:
> Dear Peter Korsgaard,
> 
> On Wed, 03 Dec 2014 23:32:08 +0100, Peter Korsgaard wrote:
> >  >> @@ -23,6 +25,9 @@ define RP_PPPOE_INSTALL_TARGET_CMDS
> >  >> for ff in $(RP_PPPOE_TARGET_FILES); do \
> >  >> $(INSTALL) -m 0755 $(@D)/src/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
> >  >> done
> >  >> +	for ff in $(RP_PPPOE_TARGET_SCRIPTS); do \
> >  >> +		$(INSTALL) -m 0755 $(@D)/scripts/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
> >  >> +	done
> > 
> >  > Both variables do the same thing.
> > 
> > No, they copy from two different subdirs?
> 
> Gaah, my bad, I overlooked that. Indeed, both variables are needed
> then. So the patch looks OK to me.
> 
> Sorry for the noise :/

On a second thought, we could do:

RP_PPPOE_TARGET_FILES = src/foo src/bar scripts/baz scripts/bleh

and then do:

	for ff in $(RP_PPPOE_TARGET_FILES); do \
		$(INSTALL) -m 0755 $(@D)/$$ff $(TARGET_DIR)/usr/sbin/$$ff || exit 1; \
	done

Not sure it matters much, though.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list