[Buildroot] [PATCH 1/4] pkg-download: check for already downloaded file in the download wrapper

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Dec 2 08:26:36 UTC 2014


Dear Yann E. MORIN,

On Tue,  2 Dec 2014 00:24:06 +0100, Yann E. MORIN wrote:
> Instead of repeating the same test again and again in all our download
> rules, just delegate the check for an already downloaded file to the
> download wrapper.
> 
> This clears up the path for doing the hash checks on a cached file
> before the download.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Cc: Peter Korsgaard <jacmet at uclibc.org>
> Cc: Gustavo Zacarias <gustavo at zacarias.com.ar>

It has the consequence of doing another fork+exec of a shell script for
all files, even if they have already been downloaded. I don't know if
this is really measurable compared to the overall build time, though,
except maybe on some cases like "make source". So maybe this is OK.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list