[Buildroot] [PATCH 1/1] package/dnsmasq: let init script cleanup stale pidfile

Gustavo Zacarias gustavo at zacarias.com.ar
Tue Dec 9 20:04:00 UTC 2014


On 11/15/2014 01:27 PM, Jörg Krause wrote:

> dnsmasq does not clean up its pidfile after termination. Do this manually.
> 
> Supersedes: [PATCH 1/1] package/dnsmasq: cleanup run-time files in init script
> https://patchwork.ozlabs.org/patch/411015/

Hi.
Does it fix anything in particular other than looks?
Looking at the dnsmasq source it does an unlink() on successful
startup/fork so any previous pidfile doesn't bother it at all.
I was about to say "i'd like to see the start-stop-daemon invocation
changed" but then i realized that it doesn't remove the pidfile either,
so basically any "start-stop-daemon -K -q -x" in any initscript
"suffers" from this "problem".
So even if the pidfile is on permanent storage i don't see how this can
cause issues.
Regards.



More information about the buildroot mailing list