[Buildroot] [PATCH] package/xbmc: Fix broken variable name

Peter Korsgaard jacmet at uclibc.org
Wed Aug 27 21:32:19 UTC 2014


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Bernd, All,
 > On 2014-08-27 22:41 +0200, Bernd Kuhls spake thusly:
 >> BR2_PACKAGE_XBMC_DBUS is provided by package/xbmc/Config.in
 >> 
 >> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
 >> ---
 >> package/xbmc/xbmc.mk |    2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)
 >> 
 >> diff --git a/package/xbmc/xbmc.mk b/package/xbmc/xbmc.mk
 >> index bdd634e..0bb6724 100644
 >> --- a/package/xbmc/xbmc.mk
 >> +++ b/package/xbmc/xbmc.mk
 >> @@ -64,7 +64,7 @@ XBMC_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/interface/vcos/pthreads
 >> LIBS="-lvcos -lvchostif"
 >> endif
 >> 
 >> -ifeq ($(BR2_PACKAGE_DBUS),y)
 >> +ifeq ($(BR2_PACKAGE_XBMC_DBUS),y)
 >> XBMC_DEPENDENCIES += dbus
 >> endif

 > No, because the user can still select the package DBUS directly and
 > since XBMC has no option to disable DBUS, we still want DBUS to be built
 > before XBMC.

 > But granted, this is not obvious from the variable name.

Then we should imho get rid of the XBMC_DBUS option if that option
doesn't do anything.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list