[Buildroot] [PATCH] package/infra: fix downloading versions with a slash

Thomas De Schampheleire patrickdepinguin at gmail.com
Sun Aug 24 18:31:59 UTC 2014

On Thu, Aug 21, 2014 at 4:45 PM, Thomas De Schampheleire
<patrickdepinguin at gmail.com> wrote:
> On Tue, Aug 19, 2014 at 7:21 PM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>> Since cset 54456cc (infra: consistently use double dollar signs...), it
>> is no longer possible to download versions with a slash in it, because
>> the _DL_VERSION variable is second-expanded, but the _VERSION variable
>> is immediately-expanded to have '/' substitued with '_'.
>> So, _DL_VERSION is only expanded at the time it is evaluated, and by
>> that time, we've lost the slashes in _VERSION.
>> Make the _DL_VERSION variables immediately-evaluated.
>> Fixes:
>>     https://bugs.busybox.net/show_bug.cgi?id=7328
>> Reported-by:  Vincent Stehlé <vincent.stehle at freescale.com>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>> Cc:  Vincent Stehlé <vincent.stehle at freescale.com>
> Acked-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> Tested-by: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> (tested by temporary setting DTC_VERSION to 'refs/tags/v1.4.0' as
> proposed in the bug report)

This patch should be applied to master, according to me.

Best regards,

More information about the buildroot mailing list