[Buildroot] [PATCH v2 5/6] gendoc infra: Remove the manual* target from .PHONY

Thomas De Schampheleire patrickdepinguin at gmail.com
Sun Aug 24 13:03:32 UTC 2014


On Thu, Aug 21, 2014 at 10:25 PM, Samuel Martin <s.martin49 at gmail.com> wrote:
> This is not needed because none of these targets are also the name of a
> generated file.
>
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
>
> ---
> changes v1 -> v2:
> - no change
> ---
>  docs/manual/manual.mk | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/docs/manual/manual.mk b/docs/manual/manual.mk
> index 016246c..437eccf 100644
> --- a/docs/manual/manual.mk
> +++ b/docs/manual/manual.mk
> @@ -143,7 +143,6 @@ $(call GENDOC_INNER,$(pkgname),epub,epub,epub,ePUB)
>  clean: $(pkgname)-clean
>  $(pkgname)-clean:
>         $$(Q)$$(RM) -rf $$(BUILD_DIR)/$(pkgname)
> -.PHONY: $(pkgname) $(pkgname)-clean manual-update-lists

I do not agree with your reasoning that because these targets are not
a file, PHONY is not needed.
The same could be said for the
.PHONY: $(1)-$(3)
line in GENDOC_INNER, and yet PHONY is not removed there.

>From the make manual [1]

"There are two reasons to use a phony target: to avoid a conflict with
a file of the same name, and to improve performance.
...
Since it knows that phony targets do not name actual files that could
be remade from other files, make skips the implicit rule search for
phony targets (see Implicit Rules). This is why declaring a target
phony is good for performance, even if you are not worried about the
actual file existing"

So according to me, the PHONY declarations should remain.

In fact, all package infrastructures could use such PHONY
declarations, but they currently do not have them.

Best regards,
Thomas

[1] http://www.gnu.org/software/make/manual/make.html#Phony-Targets


More information about the buildroot mailing list