[Buildroot] [PATCH 1/1] MPD: Add jack output support option

Gustavo Zacarias gustavo at zacarias.com.ar
Fri Aug 8 12:49:00 UTC 2014

On 08/08/2014 05:14 AM, Pieter De Gendt wrote:

A couple of details...

> +	bool "jack2"
> +	depends on BR2_LARGEFILE # libsndfile
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> +	depends on BR2_USE_MMU # fork()
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	select BR2_PACKAGE_JACK2
> +	help
> +	  Enable jack output support.
> +

The THREADS, MMU and LIBSTDCPP depends are unnecessary since mpd already
requires them, so you can drop them like it's already done for all of
the other options for mpd.
Also you're missing a comment when LARGEFILE & ATOMIC_INTRINSICS aren't
available telling that jack2 isn't available, similar to what's done for
pulseaudio for example.
Alpha-sorting the menu entry would be good too.
Otherwise it looks good.
Care to send a v2 patch with these fixes?

More information about the buildroot mailing list