[Buildroot] [PATCHv3 2/5] core: allow external Config.in/makefile code to be integrated

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Nov 28 12:29:14 UTC 2013


Dear Ryan Barnett,

On Thu, 28 Nov 2013 06:09:33 -0600, Ryan Barnett wrote:

> > Ok, I think I see what you mean: creating
> > $(BR2_EXTERNAL)/package/Config.in automatically if it doesn't
> > exist. I don't have a really strong feeling about this, but my
> > initial reaction is that it's better to let the user do that by
> > himself. BR2_EXTERNAL is part of the user source tree, and I hate
> > when tools mess up with my source tree by creating files here and
> > there automatically.
> 
> I'm in agreement with Thomas on this issue. I would prefer it if the
> user has to create the file (even with it being blank). However,
> maybe we could a test within the main makefile that if BR2_EXTERNAL
> is used and there is no "package/Config.in" present we through a make
> error prompt the user to create this file. I prefer this method since
> it would be teaching the user how to correctly use this feature
> instead of doing some hidden "auto-magic".

I don't think anything special is needed. With the current patch set
(v3), if the package/Config.in file is missing in the BR2_EXTERNAL
directory, the error is quite obvious:

$ make BR2_EXTERNAL=/tmp/koin menuconfig
package/Config.in:1000: can't open file "/tmp/koin/package/Config.in"
make: *** [menuconfig] Error 1
$

(The /tmp/koin directory is empty)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list