[Buildroot] [PATCH 1/1] dbus-python: select pyexpat dependency
vsergeev at kumunetworks.com
Tue Nov 19 01:55:38 UTC 2013
I think it had to do with adding --compose to git send-email. I had
specified the path of the patch as well, but now I see it wanted to split
it up into separate emails -- one with my composed message explaining the
patch[set] and one for each of the attached patches. Makes sense now.
I see -- I will add the runtime dependency comment and resubmit here.
On Mon, Nov 18, 2013 at 3:32 PM, Thomas Petazzoni <
thomas.petazzoni at free-electrons.com> wrote:
> Dear Ivan Sergeev,
> On Mon, 18 Nov 2013 14:37:59 -0800, Ivan Sergeev wrote:
> > For some reason git send-email didn't attach the patch. I've attached it
> > here.
> git send-email never "attaches" the patch. It sends the patch inline,
> so that reviewers can hit "reply" and review your patch directly by
> replying to the e-mail.
> I think your patch is good, but you should add a comment above the new
> select line to indicate that it is a runtime dependency only (which
> explains why you're changing the Config.in only, and not the .mk file).
> Something like:
> # Runtime dependency only
> select BR2_PACKAGE...
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the buildroot