[Buildroot] [PATCH 1/1] dbus-python: select pyexpat dependency

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Nov 18 23:32:45 UTC 2013


Dear Ivan Sergeev,

On Mon, 18 Nov 2013 14:37:59 -0800, Ivan Sergeev wrote:

> For some reason git send-email didn't attach the patch. I've attached it
> here.

git send-email never "attaches" the patch. It sends the patch inline,
so that reviewers can hit "reply" and review your patch directly by
replying to the e-mail.

I think your patch is good, but you should add a comment above the new
select line to indicate that it is a runtime dependency only (which
explains why you're changing the Config.in only, and not the .mk file).
Something like:

	# Runtime dependency only
	select BR2_PACKAGE...

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list