[Buildroot] [PATCH v2] infra: introduce github helper function

Thomas De Schampheleire patrickdepinguin at gmail.com
Wed Nov 13 13:44:58 UTC 2013


On Wed, Nov 13, 2013 at 2:33 PM, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 13/11/13 14:15, Thomas De Schampheleire wrote:
>> Regarding the defconfigs: Arnout suggested adding the $(call github)
>> there as well. However, I'm not very fond of that: if you run 'make
>> savedefconfig' later it will not be preserved.
>
>  Why would it not be preserved?
>
>  The only real disadvantage is that it looks very ugly:
>
> BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,linux-sunxi,linux-sunxi,274a66a7bfcbaabb88d63e4eba161965383cc416)/linux-sunxi-274a66a7bfcbaabb88d63e4eba161965383cc416.tar.gz"

Ah, my bad. It would be preserved, indeed.

It does look awkward, but I am not strongly against nor for changing it.

But: what will be the strategy for the defconfigs with respect to
using git / http-tarball ? In a defconfig, a version bump of, say, the
kernel is actually easier with the git method, since you only have to
update BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION, while with a tarball
(with or without the github helper) you need to update the version
number in two places inside a long string.
FYI: currently the nitrogen6x defconfig uses a tarball, the others
(cubieboard, cubieboard2, raspberrypi, calao_snowball) use git.

Best regards,
Thomas



More information about the buildroot mailing list