[Buildroot] [PATCH 1/1] omniorb: add COS Naming Service
Thomas De Schampheleire
patrickdepinguin at gmail.com
Wed Nov 13 09:07:25 UTC 2013
On Tue, Nov 12, 2013 at 11:24 PM, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin at gmail.com> writes:
>>> +if BR2_PACKAGE_OMNIORB
>>> +config BR2_PACKAGE_OMNIORB_WITH_SERVICES
>>> + bool "COS Naming Service"
>>> + default y
>>> + help
>>> + omniORB COS Naming Service
>>> comment "omniORB needs a toolchain w/ C++"
>>> depends on !BR2_INSTALL_LIBSTDCPP
>> I think it makes more sense to keep this comment close to the config
>> option it applies to, thus moving the new cos option below it. I know
>> that many packages do not follow this, but I'm planning on fixing
> Careful, kconfig needs sub options to be directly under the main option,
> otherwise they don't get indented correctly in menuconfig, so your
> options are either:
> - Comment before main option
> - Comment after all the sub options
Yuk, that's a pity...
In this case my preference is to have the comment before the main
option (so as close as possible), rather than after all sub options.
What is your opinion?
More information about the buildroot