[Buildroot] [PATCH 2 of 2] infra: remove usage of pkgparentdir in favor of pkgdir

Thomas De Schampheleire patrickdepinguin at gmail.com
Tue Nov 12 11:32:06 UTC 2013

Hi Thomas,

On Tue, Nov 12, 2013 at 12:09 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Thomas De Schampheleire,
> On Tue, 12 Nov 2013 09:56:37 +0100, Thomas De Schampheleire wrote:
>> >  I think it's a better idea to choose a new name - if only to help
>> > people who are using this variable in custom packages. Or better
>> > yet, remove it completely - it's anyway not used anymore.
>> The only remaining place is in the foo-patch block, to get the
>> location of patches for that package.
>> That is outside the inner-generic-package, so we cannot use $(4)
>> anymore. How do you propose to solve that?
> Currently:
>  <foo>_DIR => build directory
>  <foo>_DIR_PREFIX => prefix of the package directory in Buildroot
>                      sources
>  <foo>_DL_DIR => location of the package download directory, for
>                  git/cvs downloads (apparently not used consistently)
> I think it would make a lot more sense to have:
>  <foo>_DIR => points to the package directory in Buildroot sources, e.g
>               package/busybox/ for Busybox. This would allow packages
>               to easily reference their own directory, to get access to
>               configuration files and others, instead of having to know
>               they are located in package/busybox/. This could also be
>               used in the patching step instead of the DIR_PREFIX thing.

Suppose we change this definition, do you suggest to change all .mk
files that currently reference package/foo to use FOO_DIR instead?
While FOO_DIR is useful for the infrastructure, like in the patching
case, I don't think it is necessary to change a file
package/foo/foo.mk to remove the hardcoded package/foo inside the
file. The likelihood of files being moved is very small, plus it will
be very hard to enforce consistent usage of FOO_DIR in favor of
package/foo in this case.

>  <foo>_BUILDDIR => points to the package build directory in $(BUILD_DIR)
>  <foo>_SRCDIR => points to the package source directory (currently
>                  identical to <foo>_BUILDDIR, would change when we
>                  introduce OOT build for packages). Actually, more than
>                  half of the patch set I have to introduce OOT is about
>                  using <foo>_SRCDIR vs <foo>_BUILDDIR in the right
>                  places.
>  <foo>_DL_DIR => same as before.

In general, I think the new variable names make sense.

Best regards,

More information about the buildroot mailing list