[Buildroot] [pkg-luarocks infra V3 01/10] luainterpreter: create virtual package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Nov 15 08:44:23 UTC 2013


Dear Thomas De Schampheleire,

On Fri, 15 Nov 2013 08:24:59 +0100, Thomas De Schampheleire wrote:

> >  config BR2_PACKAGE_LBASE64
> >         bool "lbase64"
> > +       depends on BR2_PACKAGE_HAS_LUA_INTERPRETER
> >         help
> >           A base64 library for Lua
> 
> The meaning of BR2_PACKAGE_HAS_LUA_INTERPRETER is that the user has
> selected one of lua or luajit, right?
> Is the PACKAGE in there really needed? What about
> BR2_HAS_LUA_INTERPRETER instead? This says that 'buildroot has a lua
> interpreter' and not that 'a package has a lua interpreter'.

On the other hand, we have:

 BR2_PACKAGE_HAS_OPENGL_EGL
 BR2_PACKAGE_HAS_OPENGL_ES
 BR2_PACKAGE_HAS_OPENVG
 BR2_PACKAGE_HAS_OPENMAX
 BR2_PACKAGE_HAS_POWERVR


> > +++ b/package/luainterpreter/luainterpreter.mk
> > @@ -0,0 +1,18 @@
> > +#############################################################
> > +#
> > +# Virtual package for luainterpreter
> > +#
> > +#############################################################
> > +
> > +LUAINTERPRETER_VERSION = 5.1
> 
> What is the meaning of this version? It seems to be the lua version,
> but is this relevant for a virtual package?

No, it is not relevant. Maybe we could have the policy of doing:

<foo>_VERSION = virtual
<foo>_SOURCE =

for virtual packages. This way instead of showing "unknown" in the ">>>
blabla unknown extracting" messages, we would have ">>> blabla virtual
extracting".

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list