[Buildroot] [PATCH] support/kconfig: fix 'space' to (de)select options

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Nov 13 21:55:23 UTC 2013


Dear Yann E. MORIN,

On Wed, 13 Nov 2013 22:53:13 +0100, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> 
> In case a menu has comment without letters/numbers (eg. characters
> matching the regexp '^[^[:alpha:][:digit:]]+$', for example - or *),
> hitting space will cycle through those comments, rather than
> selecting/deselecting the currently-highlighted option.
> 
> This is the behaviour of hitting any letter/digit: jump to the next
> option which prompt starts with that letter. The only letters that
> do not behave as such are 'y' 'm' and 'n'. Prompts that start with
> one of those three letters are instead matched on the first letter
> that is not 'y', 'm' or 'n'.
> 
> Fix that by treating 'space' as we treat y/m/n, ie. as an action key,
> not as shortcut to jump to  prompt.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Cc: Peter Korsgaard <jacmet at uclibc.org>
> Cc: Samuel Martin <s.martin49 at gmail.com>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> ---
> Note: I'll be running this upstream soonish.

Thanks?

> ---
>  support/kconfig/lxdialog/menubox.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Shouldn't we also update the patches in support/kconfig/patches/ ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list