[Buildroot] [PATCH 4/7] opencv: add eigen dependency

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Nov 11 22:36:41 UTC 2013


Dear Samuel Martin,

On Mon, 11 Nov 2013 22:00:10 +0100, Samuel Martin wrote:
>  menuconfig BR2_PACKAGE_OPENCV
>  	bool "opencv"
>  	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_EIGEN

Any reason to make it mandatory?

I'm sorry but I'm going to be a bit angry again. I've asked you many,
many, many times to write more descriptive commit logs. And once again,
several of your patches have just a one line title, with no explanation
whatsoever about *why* you're doing the change.

It would be really nice if you could review all your patches before you
post them, and ask yourself the question: is the reason why I'm doing
this going to be obvious for the reviewer? If the answer is even on the
slightly unsure side, then it means you need to expand with a more
detailed commit log, or more comments in the code.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list