[Buildroot] [PATCH 1/1] Generation of locales: made call to tr more robust

Thomas De Schampheleire patrickdepinguin at gmail.com
Sun Nov 10 17:01:51 UTC 2013


On Sun, Nov 10, 2013 at 5:15 PM, Arnout Vandecappelle <arnout at mind.be> wrote:
> On 10/11/13 11:17, Thomas De Schampheleire wrote:
>>
>> Thierry Bultel <thierry.bultel at wanadoo.fr> wrote:
[..]
>>> The LOWERCASE macro does not seem to exist
>>>
>>
>> It should be straightforward to implement it based on the existing
>> UPPERCASE macro. I justfind odd there'd be two ways of converting case. One
>> with direct tr and the other with a make macro...
>
>
>  The UPPERCASE macro is actually really really ugly - it's only reason of
> existing is that it's much faster than calling tr 40K times, which would be
> required because UPPERCASE is called so often.
>
>  Bottom line: I think using tr for this one situation is a better idea than
> adding another ugly lowercase macro.

It's also to create a lowercase macro that does $(shell tr '[A-Z]'
'[a-z]'), explaining that the 'ugly' non-tr implementation is not
needed because lowercase isn't called that often.
The reason that I like the centralization is that you can make one
correct implementation, and other people won't make the
forgotten-quote mistake a second time.

Also, I think [A-Z] should be replaced by [:upper:] and [a-z] by
[:lower:] as this is more generally correct.

Best regards,
Thomas


More information about the buildroot mailing list