[Buildroot] [PATCH] perf: libelf is required to compile perf

Ryan Barnett rjbarnet at rockwellcollins.com
Tue Nov 5 16:27:38 UTC 2013


Baruch Siach,

Baruch Siach <baruch at tkos.co.il> wrote on 11/05/2013 10:18:46 AM:
 
> On Tue, Nov 05, 2013 at 08:58:10AM -0600, rjbarnet at rockwellcollins.com 
wrote:
> > Andi Shyti <andi at etezian.org> wrote on 11/05/2013 08:06:27 AM:
> > > diff --git a/package/perf/Config.in b/package/perf/Config.in
> > > index 88dce93..4b651b3 100644
> > > --- a/package/perf/Config.in
> > > +++ b/package/perf/Config.in
> > > @@ -2,6 +2,7 @@ config BR2_PACKAGE_PERF
> > >     bool "perf"
> > >     depends on BR2_LINUX_KERNEL
> > >     depends on BR2_LARGEFILE
> > > +   depends on BR2_PACKAGE_LIBELF
> > 
> > Wouldn't you want this to be a select since LIBELF is required by this 

> > package? Also in the perf.mk you want to ensure that the libelf 
package is 
> > built before by adding a dependancy to the makefile.
> > 
> > ifeq ($(BR2_PACKAGE_LIBELF),y)
> > PERF_DEPENDENCIES += libelf
> > endif
> 
> When you select BR2_PACKAGE_LIBELF in Config.in there should be no need 
for 
> the 'ifeq' condition. Just add 'libelf' to PERF_DEPENDENCIES 
unconditionally.
 
You are correct. Its just habit that I do things like that.

Thanks,
-Ryan



More information about the buildroot mailing list