[Buildroot] [PATCH] manual: clarify that Config.in comments should have correct dependencies

Thomas De Schampheleire patrickdepinguin at gmail.com
Tue Nov 5 08:15:13 UTC 2013


Hi Samuel,

On Mon, Nov 4, 2013 at 10:26 PM, Samuel Martin <s.martin49 at gmail.com> wrote:

>> +
>>  These dependencies have to expressed with the appropriate 'depends on'
>
> s/have to expressed/have to be expressed/

Hmm, seems we missed this in the original patch.
But I will fix it nevertheless, thanks.

>
>>  statements in the Config.in file. Additionally, for dependencies on
>>  toolchain options, a +comment+ should be displayed when the option is
>> @@ -180,6 +181,14 @@ made visible in a comment: since it is u
>>  freely choose another target, it makes little sense to show these
>>  dependencies explicitly.
>>
>> +The +comment+ should only be visible if the +config+ option itself would
>> +be visible when the toolchain option dependencies are met. This means
>> +that all other dependencies of the package (including dependencies on
>> +target architecture and MMU support) have to be repeated on the
>> ++comment+ definition. To keep it clear, the +depends on+ statement for
>> +these non-toolchain option should be kept separate from the +depends on+
>> +statement for the toolchain options.
>> +
>>  The general format of a dependency +comment+ for package foo is:
>>  --------------------------
>>  foo needs a toolchain w/ featA, featB, featC
>
>
> Acked-by: Samuel Martin <s.martin49 at gmail.com>
> (with this little fix ;))
>

Thanks,
Thomas


More information about the buildroot mailing list