[Buildroot] [PATCH] pkg-download with git and not VERSION set in package

Thomas De Schampheleire patrickdepinguin+buildroot at gmail.com
Fri Mar 29 15:14:36 UTC 2013


Hi,

On Fri, Mar 29, 2013 at 2:51 PM, Patrick Boettcher <
pboettcher at kernellabs.com> wrote:

> I'm new to buildroot and was playing with a local git-tree. I noticed
> that things weren't working when VERSION is not set in the package.
>
> The following patch is trivial but solves the problem with the current
> implemenation.
>
> Please copy me on replies as I'm not yet subscribed.
>
> Patrick Boettcher (1):
>   pkg-download: take some more care of <PKG_>VERSION when METHOD is git
>
>  package/pkg-download.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

If the concept of this patch is accepted, then I think it should also be
done for Mercurial. The reasoning is the same, the only difference is that
HEAD is called 'tip'.

Also, I think you should put a comment about this in the code, because it
is not trivial at first reading that HEAD/tip will always be the version
specified in the package, if any.

Best regards,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130329/33fe2a45/attachment.html>


More information about the buildroot mailing list