[Buildroot] [PATCH 1/1] busybox: Add upstream patch to avoid occasional mdev SIGSEGV.

Raúl Sánchez Siles rasasi78 at gmail.com
Wed Jun 12 06:24:58 UTC 2013


  Hi:

El Martes, 11 de junio de 2013, Peter Korsgaard escribió:
> >>>>> "Raúl" == Raúl Sánchez Siles <rasasi78 at gmail.com> writes:
>  Raúl> This implies rename of previous patch for a correct patch ordering.
>  Raúl> Signed-off-by: Raúl Sánchez Siles <rasasi78 at gmail.com>
>  Raúl> ---
>  Raúl>  ...21.0-mdev.patch => busybox-1.21.0-mdev_1.patch} |    0
>  Raúl>  .../busybox-1.21.0-mdev_2_check_ACTION.patch       |   32
> ++++++++++++++++++++
> 
> I would prefer to not rename the existing patch, as it makes it less
> clear where it comes from (http://busybox.net/downloads/fixes-1.21.0/).
> 
> It shouldn't be necessary either as '.' comes before '_' (but not before
> '-').

  That's not what I got here. I've done a more comprehensive test:
$ ls -1 |sort 
busybox-1.21.0-mdev_2_check_ACTION.patch
busybox-1.21.0-mdev_check_ACTION.patch
busybox-1.21.0-mdev-check_ACTION.patch
busybox-1.21.0-mdev.patch

  As you can see the one we want to apply first comes last compared with other 
possibilities :/

> 
> Talking of which, why is this patch not in the fixes directory? Does
> Denys not consider it important enough?

  That's probably something to ask him. I found this bug by chance and I don't 
consider it critical in any way, altough I haven't explored further 
implications. This can be reproduced when you invoke mdev without parameters. It 
will SIGSEGV since, as per current 1.21.0 code, you'll check for ACTION 
environment variable, which doesn't exist. This means a null pointer which is 
passed to index_in_strings which, in turn, passes it to the uclibc strcmp 
function that is unable to handle this case gracefully.

  Regards,

-- 
     Raúl Sánchez Siles
----->Proud Debian user<-----
Linux registered user #416098
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130612/c15bfe39/attachment-0001.asc>


More information about the buildroot mailing list