[Buildroot] [PATCH 1/1] manual: correct error in github tarball information

Peter Korsgaard jacmet at uclibc.org
Fri Jun 7 08:50:23 UTC 2013

>>>>> "Samuel" == Samuel Martin <s.martin49 at gmail.com> writes:

 >> ------------------------
 >> FOO_VERSION = 1234567
 >> -FOO_SITE = http://github.com/<user>/<package>/tarball/<branch>
 >> +FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
 >> ------------------------

 Samuel> I'd have slightly reword the whole section, since there is no
 Samuel> difference between FOO_VERSION being a tag or a commit id,
 Samuel> something like this:

 Samuel> ---
 Samuel> ------------------------
 Samuel> FOO_VERSION = v1.0 # tag or commit ID
 Samuel> FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
 Samuel> ------------------------

 Samuel> .Notes
 Samuel> - The FOO_VERSION can either be a tag or a commit ID.
 Samuel> - The tarball name generated by github matches the default one from
 Samuel> Buildroot (e.g.: +foo-1234567.tar.gz+),
 Samuel> so it is not necessary to specify it in the +.mk+ file.
 Samuel> - When using a commit ID as version, usually the first 7 characters of
 Samuel> the SHA1 are enough.

Agreed. I've fixed this in git now, thanks.

Bye, Peter Korsgaard

More information about the buildroot mailing list