[Buildroot] [PATCH 4/4] toolchain: instrument external toolchain wrapper

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Jul 18 21:32:56 UTC 2013

Dear Yann E. MORIN,

I like the feature, but it would be nice if the coding was more
consistent with the rest of the code, see below:

On Thu, 18 Jul 2013 23:24:15 +0200, Yann E. MORIN wrote:

> +	if( getenv("BR_DEBUG_WRAPPER") ) {

No space after ( and before ).

> +		fprintf( stderr, "path='%s'\n", path );


> +		int i;

Variable declaration in the middle of the code. I know it's C99 ok, but
I'd prefer not to have that (just like the kernel).

> +		for( i=0; args[i]; i++ ) {

		for (i = 0; args[i]; i++)

> +			fprintf(stderr, "argv[%d]='%s'\n", i, args[i] );

Ditto space before ).

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.

More information about the buildroot mailing list