[Buildroot] [PATCH] Makefile: unset MAKEFLAGS

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jul 13 14:07:20 UTC 2013


Dear Bjørn Forsman,

On Fri, 12 Jul 2013 19:07:58 +0200, Bjørn Forsman wrote:

> > I believe it is much better that Buildroot chokes on a select list of
> > variables, warn about a few others, and accept the rest.
> 
> If you think about it, the downloader is actually a bit different from
> the builder. At some point Buildroot will (like all other build
> systems) grow support for checking each downloaded file against
> checksums specified in the package build file. And once you have that,
> it doesn't really matter how dirty the environment in the *downloader*
> is, because it will be guaranteed to match the checksum, or fail. It
> is only in the *builder* that the environment must be clean.

I am not sure to understand why you separate the download side and the
build side here. Both are done with Buildroot makefiles, there is
nothing different in terms of environment variables between those
steps.

> Are there any reasons for allowing env vars, other than BR2_*, to slip
> through from host and into the Buildroot *builder* processes? I cannot
> think of any.

Yes, we allow passing HOSTCC, UCLIBC_CONFIG_FILE, BUSYBOX_CONFIG_FILE,
and a bunch of other environment variables (see the Buildroot manual).
Also, some environment variables like LD_LIBRARY_PATH or LD_PRELOAD
should just be usable by the user, if he has some funky setup that
requires those environment variables to hold special values.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list