[Buildroot] [PATCH v2] pkg-infra: add <pkg>_CONFIG_FIXUP to fix *-config files
stefan.froberg at petroprogram.com
Thu Jan 10 21:15:02 UTC 2013
10.1.2013 22:47, Yann E. MORIN kirjoitti:
> Stefan, All,
> On Thursday 10 January 2013 Thomas Petazzoni wrote:
>> On Thu, 10 Jan 2013 21:52:39 +0200, Stefan Fröberg wrote:
>>> For example:
>>> DIVINE_CONFIG_FIXUP = divine-config
>>> or for multiple files:
>>> IMAGEMAGICK_CONFIG_FIXUP = Magick-config Wand-config
>> I personally still believe that it is wrong to give just the filename
>> here and not the full path, i.e:
>> IMAGEMAGICK_CONFIG_FIXUP = \
>> $(STAGING_DIR)/usr/bin/Magick-config \
>> With just the filename, my impression is that it is just too much magic
>> happening behind the scene.
> Agreed. But I'd leave away the $(STAGING_DIR), and give full paths relative
> to the staging dir:
> IMAGEMAGICK_CONFIG_FIXUP = \
> /usr/bin/Magick-config \
> And the infrastructure automatically adds it, instead of adding
> $(STAGING_DIR)/usr/bin as it does in this patch.
> Also, I find the _FIXUP suffix to be misleading. 'fixup' conveys the
> meaning that the flaws are fixed, so I'd naturally expect that the
> *-config scripts are fixed, while this implementation removes them.
> With _FIXUP, the developper may incorrectly conclude that some sed/awk/..
> magic is done on these scripts.
Well, uh... there *is* some sed magic done to those scripts. Almost half
of the those files in my
installation provide wrong prefix, wrong exec_prefix, and worst of all,
prefix and nothing else, not even includedir and libdir (but that's
another story, another patch).
> I'd suggest FOO_CONFIG_SCRIPTS which is neutral, and does not say what
> is done with these scripts, so reading the documentation is mandatory to
> understand what is done.
Good, but im not doing that documentation patch. Like I said to Thomas,
I really suck in this
> But, as Thomas, I don't have a strong opinion either. The current situation
> is OK, if not the "best in my eyes". ;-)
> Yann E. MORIN.
Nice, two Ok votes sofar.
Can the father (Gustavo) of this <pkg>_CONFIG_FIXUP also give his vote ?
More information about the buildroot