[Buildroot] [PATCH 2/3] Add Perf tools support

Kaiwan Billimoria kaiwan.billimoria at gmail.com
Thu Jan 3 12:54:41 UTC 2013


Dear Thomas Petazzoni,

Excuse my silly stuff & poor knowledge of the 'make'/build system !  :-p
Pl see more qs below..

>> + # FIXME: Where should we place the perf kernel patch? Online?
>> + # Temporarily, at least, it's under linux/
>> + BR2_LINUX_KERNEL_PATCH += "$(HOST_DIR)/../../linux/perf.patch"
>
> No, we don't modify BR2 variables.

So, how exactly do we do this then?

>> +all:
>
> Arggh, this is *horrible*. Why do you believe you are allowed to
> overload the "all" target?

Right. Forgive my basic qs, but what's the right approach?

>
> That said, I am not sure we want this thing in linux/linux.mk. Maybe
> I'd prefer a package/perf/perf.mk, which depends on BR2_LINUX_KERNEL
> and re-uses the source code extracted in $(LINUX_DIR).

Ok, will try working on this approach as well.
Not free now for a bit, will come back to this soon & keep you posted..

Thanks again for all valuable inputs..
Best,
Kaiwan.

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com


More information about the buildroot mailing list