[Buildroot] [PATCH 3/8] package/Makefile.in: update/fix HOST_PATH variable
s.martin49 at gmail.com
Thu Feb 7 16:48:13 UTC 2013
2013/2/7 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Dear Samuel Martin,
> On Sun, 30 Dec 2012 23:54:10 +0100, Samuel Martin wrote:
>> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
>> package/Makefile.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/package/Makefile.in b/package/Makefile.in
>> index cc8f320..dd04e25 100644
>> --- a/package/Makefile.in
>> +++ b/package/Makefile.in
>> @@ -165,7 +165,7 @@ HOST_CFLAGS ?= -O2
>> HOST_CFLAGS += $(HOST_CPPFLAGS)
>> HOST_CXXFLAGS += $(HOST_CFLAGS)
>> HOST_LDFLAGS += -L$(HOST_DIR)/lib -L$(HOST_DIR)/usr/lib
>> # hostcc version as an integer - E.G. 4.3.2 => 432
>> HOSTCC_VERSION:=$(shell $(HOSTCC_NOCCACHE) --version | \
> I am ok with the patch, and also your 4/8, but I really believe you
> should be more verbose in the commit log. Here the only information is
> "update/fix HOST_PATH variable".
I agree and I may be more guilty than anyone else since I regularly
ask for more details. ;)
> But why? What is the reason? What are
> the impacts? It is especially true when we look at those patches with a
> little bit of delay as is the case now.
Well, I think I already answered this:
I planned to re-spin part of the serie, but would like some inputs to
"do we need 2 distinct variables for this?"
So, meanwhile, if you prefer merge this patch as is (with a commit
message more verbose), tell me, I'll repost it shortly.
More information about the buildroot