[Buildroot] [PATCH 02/11] manual: minor fix in patch-policy.txt

Samuel Martin s.martin49 at gmail.com
Tue Feb 26 09:44:39 UTC 2013


Hi Thomas,

2013/2/26 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Dear Samuel Martin,
>
> On Mon, 25 Feb 2013 22:31:22 +0100, Samuel Martin wrote:
>
>> +- If a patch does some package version fixes, this should be documented in the
>> +commit message of the patch itself (or the message prepended to the 'diff'
>> +itself).
>
> I am not sure to understand this part.
I don't know how to explain this clearly.

My point is, for some packages, BR does not provide the latest version,
but some fix may be available upstream, so they have been backported in BR
(e.g.: package/libglib2/libglib2-make-codegen-python2-python3-compliant.patch).

Any suggestion to explain this point in a better way is welcome.

>
>> +* Otherwise, patch files matching +<packagename>-<description>.patch+
>> +  are applied following the +ls+ command order.
>
> Shouldn't we be enforcing a <packagename>-<number>-<description>.patch
> policy, in order to ensure that patches are applied in the right order?
Well, here I stick to the current apply-patches.sh implementation.

Regards,

-- 
Samuel


More information about the buildroot mailing list