[Buildroot] [PATCH 2/4] fs/ext2: add ability to build ext3/4 too
jacmet at uclibc.org
Tue Feb 19 12:03:10 UTC 2013
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
>> if BR2_TARGET_ROOTFS_EXT2
>> + bool "ext generation"
Arnout> Given the way it appears in menuconfig, I think this will be hard to
Arnout> understand for many users. Perhaps "ext generation (ext2, ext3 or
Or simply ext variant?
>> + default BR2_TARGET_ROOTFS_EXT2_2
Arnout> Although this matches the current default, doesn't it make
Arnout> more sense to "bump" to ext4?
Possibly. It would break existing configs though.
>> +config BR2_TARGET_ROOTFS_EXT2_2
>> + bool "ext2"
>> +config BR2_TARGET_ROOTFS_EXT2_3
>> + bool "ext3"
>> + select BR2_PACKAGE_HOST_E2FSPROGS
Arnout> We don't usually select the host package. On the other hand, the
Arnout> support for user-selectable host packages is pretty recent, so we
Arnout> don't have a real tradition for this.
I would argue that we should keep kconfig and makefiles consistent when
possible, so when we have a user selectable host package (kconfig
symbol), we should select it.
Bye, Peter Korsgaard
More information about the buildroot