[Buildroot] [PATCH] add pre-build script
spenser at gillilanding.com
Thu Feb 14 01:04:30 UTC 2013
On Feb 13, 2013 4:28 PM, "Arnout Vandecappelle" <arnout at mind.be> wrote:
> On 13/02/13 14:54, Joe Halpin wrote:
>> This is a patch to add a pre-build script, which runs before the build
>> starts. This lets us setup symlinks and such before the build starts,
>> which makes things easier and cleaner for us. Maybe it will for other
>> people too. This was made from the 20.12.11 release.
> Could you clarify a bit more what the use case is? Then we can consider
if there are maybe better ways to achieve it.
> Also, a properly formatted patch has a commit message which is formatted
as follows: a single summary line of max. 80 characters, an empty line, one
or more paragraphs explaining why the patch is necessary, your
Signed-off-by line, a line containing three dashes, the patch changelog (if
you resubmit it). Look at other patches on the list for examples. And you
should send the patch with git send-email or similar, so that whitespace is
retained and we can comment in-line.
> Regarding the patch itself: why do you pass $(TARGET_DIR) as an
argument? Since the 'dirs' step comes after the 'prepare' step,
$(TARGET_DIR) doesn't exist yet...
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
> buildroot mailing list
> buildroot at busybox.net
I have a use case for this. In Microblaze builds, it would be nice to
generate optimal cflags from the dts/mhs for use in all software. This
could be accomplished by a pre script.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the buildroot