[Buildroot] [PATCH v2] vim: Add post-install hook to remove documentation from target
markos.chandras at gmail.com
Tue Feb 12 11:59:16 UTC 2013
On 12 February 2013 11:23, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Markos Chandras,
> On Tue, 12 Feb 2013 10:51:39 +0000, Markos Chandras wrote:
>> From: Markos Chandras <markos.chandras at imgtec.com>
>> Signed-off-by: Markos Chandras <markos.chandras at imgtec.com>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> We often try to keep the define ... endef block within the ifneq
> condition, since there is no reason for the VIM_REMOVE_DOCS variable to
> be defined if it is useless. But it's not something that has been done
> systematically in the entire code base (for example, the
> VIM_INSTALL_RUNTIME_CMDS just above your patch, doesn't follow this
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
I agree but seeing how the VIM_INSTALL_RUMTIME_CMDS is implemented, I
figured this was the recommended practice.
If you need me to submit a new patch please let me know.
More information about the buildroot