[Buildroot] [RFC] Removing CLEAN_CMDS and UNINSTALL_(STAGING|TARGET)_CMDS
sho at relinux.de
Tue Feb 12 08:38:56 UTC 2013
Am 08.02.2013 23:37, schrieb Thomas Petazzoni:
> This is an RFC patch set to discuss whether or not we should keep the
> <pkg>_CLEAN_CMDS, <pkg>_UNINSTALL_TARGET_CMDS and
> <pkg>_UNINSTALL_STAGING_CMDS. It is a topic that has been discussed at
> various times in the past months/years.
the "make <pkg>-clean" handling we have is practically useless, since
some packages implement it more or less and others only remove the stamp
files or whatever. So we could either repair it or remove it.
Since the only reason to clean a package is that one has changed the
configuration "make <pkg>-dirclean" does as well. So I opt for removing
the <pkg>-clean target and the <pkg>_CLEAN_CMDS.
> A lot of packages don't implement them, we generally don't ask for
> them to be implemented when reviewing packages, and the uninstall
> commands are generally never updated when a package version is bumped,
> which means that they are probably bitrotting pretty quickly. We also
> have no automated way of testing these commands.
> That said, it is true that the <pkg>-clean target might be useful for
> some use cases. However, is <pkg>-uninstall really useful, considering
> that it doesn't take into account the removal of the reverse
>From buildroot's concept of defining the packages with Kconfig I did not
see the point of uninstall at all. It could either be called
automatically after removing packages from .config or, when make
<package>_uninstall is called, update .config afterwards. Both does not
seem practicable to me.
So I opt for removing this, too.
> Again, this patch set is not meant to be applied as is, it is here to
> get the discussion started. Sending the patches with it is simply a
> way to ensure that the discussion is considered seriously :-)
> Best regards,
> buildroot mailing list
> buildroot at busybox.net
More information about the buildroot