[Buildroot] [PATCH] allow wpa_supplicant to run on the dbus using the 'new' api
bear at bears.org
Tue Dec 18 15:38:21 UTC 2012
Arnout Vandecappelle wrote:
> Reviewing patches is more convenient for us if you do the following:
> * Send the patch in-line, preferably with git send-email, so we can
> give comments in-line.
Sorry. I'll keep that in mind next time. I'm a long time hacker, but
not a long-time contributor to open source. :)
Thanks for being gentle with the criticism; I am still feeling my way
around what is proper etiquette.
> * Keep the original author information - in this case, preferably by
> keeping the original git authorship.
I was only able to find a partial copy of it via a google search, so I
didn't have the original. I didn't think about it at the time, but I
should have gone and looked in the mailing list archives.
> I did a quick comparison with Sven's patch and I don't see why you
> removed the BR2_PACKAGE_WPA_SUPPLICANT_DBUS_OLD option.
Purely ignorance on my part -- I didn't realize that it was a both/and
rather than an either/or for that option.
The reason I needed the fix is because connman is expecting the new API,
and so fails to find wireless devices without wpa_supplicant using it.
The dbus fix I sent seperately makes dbus properly handle activation, so
that it can start the wpa_supplicant. The test in the autoconf fails and
says the fixes need to be done manually. (I suspect it is because dbus
is cross compiled, so the tests can't run on the host)
More information about the buildroot