[Buildroot] [PATCH 09/15] Makefile.package.in: Pass non-prefixed name as argument to GENTARGETS_INNER.

Peter Korsgaard jacmet at uclibc.org
Fri Sep 30 06:31:43 UTC 2011

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> From: Quotient Remainder <quotientvremainder at gmail.com>

 Thomas> Instead of effectively running s/^host-// on the package name,
 Thomas> just pass the non-prefixed name to GENTARGETS_INNER.  This
 Thomas> removes the need to ban packages with names starting with
 Thomas> "host-".

 Thomas> Signed-off-by: Quotient Remainder <quotientvremainder at gmail.com>

As I said before, real name please.
 Thomas>  #
 Thomas>  # Build step. Only define it if not already defined by the package .mk
 Thomas>  # file.
 Thomas>  #
 Thomas> -ifndef $(2)_BUILD_CMDS
 Thomas> -ifeq ($(5),target)
 Thomas> -define $(2)_BUILD_CMDS
 Thomas> +ifndef $(4)_BUILD_CMDS

I believe this should be 3 and not 4. Even with this fixed I have the
build breaking in various odd ways, so I'm dropping this patch for now.

Bye, Peter Korsgaard

More information about the buildroot mailing list