[Buildroot] [PATCH 1/3] lsof: fix permission of extracted files

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Oct 21 06:55:40 UTC 2011


Le Fri, 21 Oct 2011 00:05:23 +0200,
Damian Kaczmarek <damian at veritymedical.co.uk> a écrit :

> +LSOF_EXTRACT_CMDS = \
> +        $(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
> +                $(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
> +        $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -

I would prefer:

define LSOF_EXTRACT_CMDS
        $(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
                $(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
        $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -
endef

since this is what we use for all other pkg_something_CMDS.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list