[Buildroot] [PATCH] add package tango-icon-theme and dependency icon-naming-utils

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Oct 10 14:10:08 UTC 2011


Hello Klaus,

Le Mon, 10 Oct 2011 15:31:36 +0200,
Klaus Schwarzkopf <schwarzkopf at sensortherm.de> a écrit :

> Signed-off-by: Klaus Schwarzkopf <schwarzkopf at sensortherm.de>
> ---
>  package/Config.in                              |    1 +
>  package/icon-naming-utils/icon-naming-utils.mk |   11 +++++++++++
>  package/tango-icon-theme/Config.in             |    6 ++++++
>  package/tango-icon-theme/tango-icon-theme.mk   |   15 +++++++++++++++

We usually have one patch per new package.

> +$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))

This should be:

$(eval $(call AUTOTARGETS))

in the Git version of Buildroot. The documentation has not yet been
updated in that regard.

> +TANGO_ICON_THEME_VERSION = 0.8.90
> +TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
> +TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
> +
> +TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig

Here you're going to build a target package (tango-icon-theme) based on
library informations of the host. This looks wrong. pkg-config already
looks in $(STAGING_DIR)/usr/lib/pkgconfig.

Could you detail why this is needed ?

> +$(eval $(call AUTOTARGETS,package,tango-icon-theme))

$(eval $(call AUTOTARGETS))

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list