[Buildroot] [PATCH v5] package: add opencv

Samuel Martin s.martin49 at gmail.com
Thu Oct 27 11:41:12 UTC 2011


2011/10/26 Arnout Vandecappelle <arnout at mind.be>

> On Monday, October 24, 2011 15:35:32 Peter Korsgaard wrote:
> [snip]
> >  Samuel> +# Build type
> >  Samuel> +OPENCV_CONF_OPT += -DCMAKE_BUILD_TYPE=$(if
> > $(BR2_ENABLE_DEBUG),Debug,Release)
> >
> > While this works it looks quite different than other packages - We
> > normally do:
> >
> > OPENCV_CONF_OPT += \
> >                 blah=.. \
> >                 blih=.. \
> >                 bloh=..
> >
> > ifeq ($(BR2_PACKAGE_BLAH))
> > OPENCV_CONF_OPT += BLAH=on
> > OPENCV_DEPENDENCIES += blah
> > else
> > OPENCV_CONF_OPT += BLAH=OFF
> > endif
> >
> > ..
> >
> > I've rewritten it to use that form.
>
>  Actually, for that particular one you haven't :-)
>
>  Also I think it's important to use
>
> ifeq ($(BR2_PACKAGE_BLAH),y)
>

Actually, in the 1st version of the patch it was this form, then I changed
it following the comments of Thomas P. ...

Using one or the other form does not change anything, it is just a matter of
consistency.

Defining some rules like these can certainly be gathered into a "developer
guide-line" or something like that.
If everybody follows the same form/standard (whatever you call it) it will
make easier processing submitted patches.
It could also allow to develop some checker scripts.

Regards,

Sam


>
>  so you can easily disable it on the command line with
>
> make BR2_PACKAGE_BLAH=n
>
> (Of course, 'make BR2_PACKAGE_BLAH=' would still work, but it's less
> intuitive.)
>
>  Regards,
>  Arnout
>
>
> --
> Arnout Vandecappelle                               arnout at mind be
> Senior Embedded Software Architect                 +32-16-286540
> Essensium/Mind                                     http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR
> Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111027/84a0b624/attachment-0001.html>


More information about the buildroot mailing list