[Buildroot] [PATCH 4/4] Add the libplayer package

Peter Korsgaard jacmet at uclibc.org
Thu Oct 6 09:08:59 UTC 2011

>>>>> "Maxime" == Maxime Ripard <maxime.ripard at free-electrons.com> writes:

 Maxime> From: Maxime Ripard <maxime at free-electrons.com>
 Maxime> Signed-off-by: Maxime Ripard <maxime at free-electrons.com>

Committed with minor changes, thanks.

 Maxime> diff --git a/package/multimedia/libplayer/Config.in b/package/multimedia/libplayer/Config.in
 Maxime> new file mode 100644
 Maxime> index 0000000..38315ec
 Maxime> --- /dev/null
 Maxime> +++ b/package/multimedia/libplayer/Config.in
 Maxime> @@ -0,0 +1,27 @@
 Maxime> +config BR2_PACKAGE_LIBPLAYER
 Maxime> +	depends on BR2_LARGEFILE
 Maxime> +	bool "libplayer"
 Maxime> +	help
 Maxime> +	  libplayer provides a generic A/V API that relies on various multimedia
 Maxime> +	  player for Linux systems. It currently supports MPlayer, xine VLC and
 Maxime> +	  GStreamer only
 Maxime> +
 Maxime> +	  http://libplayer.geexbox.org/
 Maxime> +
 Maxime> +comment "Libplayer requires a toolchain with LARGEFILE support"
 Maxime> +	depends on !BR2_LARGEFILE
 Maxime> +

This should be at the bottom of the file (after the sub options),
otherwise those don't get indented under BR2_PACKAGE_LIBPLAYER

 Maxime> +	depends on BR2_PACKAGE_MPLAYER
 Maxime> +	bool "Libplayer mplayer backend"

It's not really clear for people who don't know the libplayer
implementation that they need to go and enable mplayer/gstreamer to get
libplayer to do anything useful, so I've changed these 'depends on' to
select like we normally do for libraries (yes, mplayer isn't really a
library, but here it is used as one).

At the same time I tweaked the option names a bit.

Bye, Peter Korsgaard

More information about the buildroot mailing list